fix: add gql request name support #2419
Conversation
| @@ -155,7 +155,7 @@ export class GraphQlRequestService { | |||
| ): Observable<TResponse> { | |||
| return this.apollo | |||
| .query<TResponse>({ | |||
| query: gql(requestString), | |||
| query: gql(`query ${options?.name ?? ''} ${requestString}`), | |||
There was a problem hiding this comment.
Will this work with current batching behavior? I would think it would either break or prevent batching - neither good. Work to push the name further down so multiple named queries can be grouped (you might want to use alias rather than a query name, for example).
Codecov Report
@@ Coverage Diff @@
## main #2419 +/- ##
===========================================
- Coverage 82.83% 57.00% -25.83%
===========================================
Files 921 921
Lines 20547 20549 +2
Branches 3241 3243 +2
===========================================
- Hits 17020 11714 -5306
- Misses 3402 8445 +5043
- Partials 125 390 +265
... and 211 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Unit Test Results 4 files ±0 310 suites ±0 49m 59s ⏱️ + 6m 59s For more details on these failures, see this check. Results for commit 100d43c. ± Comparison against base commit 02e5209. |
Currently, we fire a lot of queries of the same type, for example: we may fire up to 10 different entity queries for different use cases. Since we have a number of queries of the same type, debugging becomes difficult for the teams as they have to look for the schema to realize which query is failing and what is the use case.
💡 Solution
Added an optional attribute
namein the Graphql options which can be used to fire a names query depending upon the use caseBeforeAfter